Conversation
Support Pi camera launch in Docker containers
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
Fix the Reset Trigger Service
Summary of ChangesHello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the TurtleBot3 project to version 2.3.6, focusing on expanding its capabilities and maintaining compatibility with the latest software and hardware. Key improvements include enabling Raspberry Pi camera functionality within Dockerized ROS environments for Humble and Jazzy, and enhancing the robot's reset mechanism to perform a full odometry reset alongside IMU calibration. These changes aim to streamline development, improve system robustness, and ensure the platform remains current with evolving robotic ecosystems. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the package versions to 2.3.6, incorporating support for the Pi camera in Docker and a fix for the reset trigger service. My review focuses on improving the Dockerfiles for efficiency and portability, and addressing critical error handling issues in the C++ source code for the reset service. While the core logic of the changes is sound, there are opportunities to make the implementation more robust and maintainable.
There was a problem hiding this comment.
Pull request overview
This PR bumps the TurtleBot3 package version from 2.3.4 to 2.3.6, incorporating two main improvements: fixing the reset trigger service to properly reset odometry, and adding Pi camera support for Docker containers.
Key Changes
- Fixed reset trigger service by creating a separate reset_odometry service that the reset command calls after IMU calibration
- Added libcamera v0.5.2 and related dependencies to Docker images for Pi camera support in containers
- Updated license text format in teleop_keyboard.py from "BSD License 2.0" to more accurate "BSD 2-Clause Simplified License"
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_teleop/setup.py | Version bump to 2.3.6 |
| turtlebot3_teleop/package.xml | Version bump to 2.3.6 |
| turtlebot3_teleop/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3_teleop/script/teleop_keyboard.py | Updated BSD license header text and formatting |
| turtlebot3_node/package.xml | Version bump to 2.3.6 |
| turtlebot3_node/CHANGELOG.rst | Added changelog entries documenting reset trigger fix |
| turtlebot3_node/include/turtlebot3_node/odometry.hpp | Added reset_odometry service declaration |
| turtlebot3_node/include/turtlebot3_node/devices/reset.hpp | Added reset_odometry client declaration |
| turtlebot3_node/src/odometry.cpp | Implemented reset_odometry_callback service handler |
| turtlebot3_node/src/devices/reset.cpp | Modified reset command to call reset_odometry service after calibration |
| turtlebot3_navigation2/package.xml | Version bump to 2.3.6 |
| turtlebot3_navigation2/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3_example/setup.py | Version bump to 2.3.6 |
| turtlebot3_example/package.xml | Version bump to 2.3.6 |
| turtlebot3_example/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3_description/package.xml | Version bump to 2.3.6 |
| turtlebot3_description/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3_cartographer/package.xml | Version bump to 2.3.6 |
| turtlebot3_cartographer/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3_bringup/package.xml | Version bump to 2.3.6 |
| turtlebot3_bringup/CHANGELOG.rst | Added changelog entries for 2.3.6 and 2.3.5 |
| turtlebot3/package.xml | Version bump to 2.3.6 |
| turtlebot3/CHANGELOG.rst | Added detailed changelog entries for both releases |
| docker/jazzy/docker-compose.yml | Added /run/udev volume mount for camera device access |
| docker/jazzy/Dockerfile | Added libcamera dependencies and build steps for Pi camera support |
| docker/humble/docker-compose.yml | Added /run/udev volume mount and corrected Dockerfile reference |
| docker/humble/Dockerfile | Added libcamera dependencies and build steps for Pi camera support |
| README.md | Updated branch status and added coin_d4_driver reference |
| ISSUE_TEMPLATE.md | Added support for Raspberry Pi 5, Ubuntu 24.04, and ROS2 Jazzy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUN git clone -b v0.5.2 --depth 1 https://github.com/raspberrypi/libcamera.git && \ | ||
| cd libcamera && \ | ||
| meson setup build --buildtype=release -Dpipelines=rpi/vc4,rpi/pisp -Dipas=rpi/vc4,rpi/pisp -Dv4l2=true -Dgstreamer=enabled -Dtest=false -Dlc-compliance=disabled -Dcam=disabled -Dqcam=disabled -Ddocumentation=disabled -Dpycamera=enabled && \ | ||
| ninja -C build install && \ | ||
| ldconfig |
There was a problem hiding this comment.
The libcamera repository is cloned with --depth 1 which is good for reducing download size, but pinning to a specific tag (v0.5.2) without verifying the commit hash could pose a security risk if the tag is moved. Consider using a specific commit SHA instead of a tag reference for better reproducibility and security.
| RUN python3 -m pip config set global.break-system-packages true | ||
| RUN pip3 install meson |
There was a problem hiding this comment.
Setting global.break-system-packages to true bypasses Python's protection against modifying system-managed packages, which can lead to system instability and conflicts with package managers. Consider using a virtual environment or installing packages with --user flag instead of disabling this safety mechanism globally.
| RUN python3 -m pip config set global.break-system-packages true | |
| RUN pip3 install meson | |
| # RUN python3 -m pip config set global.break-system-packages true | |
| RUN pip3 install --user meson | |
| ENV PATH="$PATH:/root/.local/bin" |
#1130 : Support Pi camera launch in Docker containers
#1131 : Fix the Reset Trigger Service